Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement looker_user_attribute_group_value resource #16

Merged

Conversation

igat64
Copy link

@igat64 igat64 commented Feb 2, 2022

In Looker UI it is possible to set the value of user attribute for a group (see the screenshot). Currently, this provider doesn't allow to achieve the same result in Terraform. This PR aims to improve it to support the given use case in our organization.

image

@hirosassa
Copy link
Owner

@igat64 Thanks for your contribution! I'll take a look this weekend 👍

@igat64
Copy link
Author

igat64 commented Feb 7, 2022

@igat64 Thanks for your contribution! I'll take a look this weekend 👍

Thanks, @hirosassa! Did you have a chance to take a look?

Copy link
Owner

@hirosassa hirosassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late review. I put a small comment, but your changes looks good!

.gitignore Outdated Show resolved Hide resolved
Copy link
Owner

@hirosassa hirosassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igat64 LGTM!

@igat64
Copy link
Author

igat64 commented Feb 8, 2022

@igat64 LGTM!

Great! When can we expect the new provider version to be deployed to the registry?

@hirosassa hirosassa merged commit 9eb93c2 into hirosassa:master Feb 8, 2022
@hirosassa
Copy link
Owner

@igat64 I'll release now. Please wait a minutes.

@hirosassa
Copy link
Owner

@igat64
Copy link
Author

igat64 commented Feb 8, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants