-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo on line 373 of resource_connection.go #48
fix typo on line 373 of resource_connection.go #48
Conversation
hmmm, lint is failed. I'll take a closer look. |
There is another typo on Line 176 of the same file when using pdt_context_override block:
Should I add the fix to that to this PR? |
@jbennett7 Thanks! Let's fix it in this PR too. |
done |
Fixed typo in the documentation as well: |
Hello, I appreciate the feedback for this. Is there anything else that needs to be completed for this? Do we have a timeline for when these fixes can be implemented? |
@jbennett7 Sorry for massively late reply. I fixed CI in #50. |
Looks good! I'll merge this. @jbennett7 Thanks for your contribution and patience. |
@jbennett7 Thanks again! I released new version of this provider. |
Fix typo
terraform-provider-looker/pkg/looker/resource_connection.go
Line 373 in 89a1ec4