Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo on line 373 of resource_connection.go #48

Merged
merged 4 commits into from
Oct 7, 2023

Conversation

jbennett7
Copy link

@jbennett7 jbennett7 commented Sep 28, 2023

Fix typo

if v, ok := d.GetOk("jdbc_addtional_params"); ok {

@hirosassa
Copy link
Owner

hmmm, lint is failed. I'll take a closer look.

@jbennett7
Copy link
Author

There is another typo on Line 176 of the same file when using pdt_context_override block:

Should I add the fix to that to this PR?

@hirosassa
Copy link
Owner

@jbennett7 Thanks! Let's fix it in this PR too.

@jbennett7
Copy link
Author

done

@jbennett7
Copy link
Author

Fixed typo in the documentation as well: docs/resources/connection.md

@jbennett7
Copy link
Author

Hello,

I appreciate the feedback for this. Is there anything else that needs to be completed for this? Do we have a timeline for when these fixes can be implemented?

@hirosassa
Copy link
Owner

@jbennett7 Sorry for massively late reply. I fixed CI in #50.
Cloud you please rebase current master?
I'll merge this PR after rebase.

@hirosassa
Copy link
Owner

Looks good! I'll merge this. @jbennett7 Thanks for your contribution and patience.

@hirosassa hirosassa merged commit 5c82409 into hirosassa:master Oct 7, 2023
2 checks passed
@hirosassa
Copy link
Owner

@jbennett7 Thanks again! I released new version of this provider.
https://github.com/hirosassa/terraform-provider-looker/releases/tag/v0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants