Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add user deletion protection #53

Merged
merged 4 commits into from
Dec 1, 2024
Merged

add user deletion protection #53

merged 4 commits into from
Dec 1, 2024

Conversation

yazgoo
Copy link

@yazgoo yazgoo commented Nov 27, 2024

when we update the admin group it removes terraform from the admins.

This would allow to protect from this

@hirosassa
Copy link
Owner

@yazgoo Thanks for your contribution! and this change looks great!
Cloud you update terraform doc?
ref: https://github.com/hirosassa/terraform-provider-looker/actions/runs/12053571494/job/33725872021?pr=53

@hirosassa
Copy link
Owner

@yazgoo Again, thank you for your contribution!

@hirosassa hirosassa merged commit 9f0aa5d into hirosassa:master Dec 1, 2024
2 checks passed
@yazgoo
Copy link
Author

yazgoo commented Dec 2, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirosassa hirosassa hirosassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yazgoo @hirosassa