Add support for error reporting #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-yomo
force-pushed
the
add-support-for-error-reporting
branch
from
1a3e326
to
72ee21d
Compare
k-yomo
force-pushed
the
add-support-for-error-reporting
branch
from
72ee21d
to
ded5e8b
Compare
|
Ah, just found this discussion... |
k-yomo
force-pushed
the
add-support-for-error-reporting
branch
from
ded5e8b
to
dd25cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #11
This PR adds support for error reporting as an option. Most of the implementation are in reference to zapdriver's implementation
#17 or similar PR to wrap all zerolog
Event's methods must be merged first to make this PR work.