-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: consolidate datastore and burn datastore data #1562
Conversation
4ec8bc1
to
b61b904
Compare
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
3b7bc89
to
b35e449
Compare
I like where this is going. Was this in relation to some issue or just a cleanup? |
@tippenein Basically we went realistc block times in simnet between burn blocks and between stacks blocks. We were only tracking one type of blocks so far (doesn't really matter which type, since we had a 1:1 relation between burn and stacks blocks). |
4b1499d
to
6b6b0ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the datastore
changes, and they seem to be ok. I added some remarks that could be improved, if applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes on datastore LGTM!
50c2f49
to
799fff8
Compare
fix: #1540
Description
The simnet memory datastore was only able to store blocks data for pre-nakamoto blocks (with 1 stacks block per burn block).
With this refactor, we now handle multiple stacks-block per burn block.
Datastore
becomesClarityDatastore
and holds the key/value store for Clarity data.BurnDatastore
becomes theDatastore
and holds all of the stacks block and burn blocks dataBlockInfo
has been removed in favor ofBurnBlockInfo
andStacksBlockInfo