Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle size of the stacks package is really huge #1120

Closed
pradel opened this issue Oct 19, 2021 · 4 comments · Fixed by #1150, #1156 or #1160
Closed

Bundle size of the stacks package is really huge #1120

pradel opened this issue Oct 19, 2021 · 4 comments · Fixed by #1150, #1156 or #1160
Assignees
@ahsan-javaid
Milestone
Bundle Size Depen...

Comments

@pradel
Copy link
Contributor

pradel commented Oct 19, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

I have a super simple next.js app, and the bundle size of the js files is in total 295 kB gzipped. Without stacks.js dependencies, the size is around 65 kB. So most of my bundle size is coming from the stacks dependencies as you can see in the following screenshot.

Capture d’écran 2021-10-19 à 13 24 25

Describe the solution you'd like

Using stacks.js libs shouldn't make my app slow to load for my users.

Opening the issue to start the discussion around improvements that can be made in stacks.js
@pradel pradel mentioned this issue Oct 19, 2021
Closed
9 tasks
@rafaelcr
Copy link
Collaborator

We are aware of this issue, we'll get back to you ASAP

@ahsan-javaid ahsan-javaid self-assigned this Dec 2, 2021
@ahsan-javaid ahsan-javaid mentioned this issue Dec 16, 2021
Merged
9 tasks
@ahsan-javaid ahsan-javaid linked a pull request Dec 16, 2021 that will close this issue
Offload bn.js #1150
Merged
9 tasks
@ahsan-javaid ahsan-javaid mentioned this issue Jan 4, 2022
Merged
9 tasks
@ahsan-javaid ahsan-javaid linked a pull request Jan 4, 2022 that will close this issue
[Bundle Size] Offload lodash dependency #1156
Merged
9 tasks
@ahsan-javaid ahsan-javaid mentioned this issue Jan 17, 2022
Merged
9 tasks
@ahsan-javaid ahsan-javaid linked a pull request Jan 17, 2022 that will close this issue
[Bundle Size][Transactions] Use noble-secp256k1 to replace elliptic dependency #1160
Merged
9 tasks
@pradel
Copy link
Contributor Author

pradel commented Jan 18, 2022

Can you reopen the issue? I don't think this one is solved yet.

@pradel
Copy link
Contributor Author

pradel commented Jan 18, 2022

@reedrosenbluth

@zone117x zone117x reopened this Jan 18, 2022
@janniks janniks reopened this Feb 15, 2022
This was referenced Feb 17, 2022
Closed
Closed
@janniks janniks added this to the Bundle Size Dependencies milestone Feb 23, 2022
@janniks
Copy link
Collaborator

janniks commented Feb 23, 2022 •
edited
Loading

Moving this to the relevant milestone and sub-issues
https://github.com/hirosystems/stacks.js/milestone/56

@janniks janniks closed this as completed Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahsan-javaid ahsan-javaid

Labels
None yet
Projects
None yet
Milestone
Bundle Size Dependencies
5 participants
@rafaelcr @zone117x @pradel @janniks @ahsan-javaid