Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offload elliptic from encryption #1192

Closed
5 tasks
janniks opened this issue Feb 17, 2022 · 0 comments · Fixed by #1200
Closed
5 tasks

Offload elliptic from encryption #1192

janniks opened this issue Feb 17, 2022 · 0 comments · Fixed by #1200
Assignees
@ahsan-javaid
Milestone
Bundle Size Depen...

Comments

@janniks
Copy link
Collaborator

janniks commented Feb 17, 2022 •
edited
Loading

please add tests similar to previous PR, to check for interoperability with elliptic (i.e. keep elliptic in devDependencies)

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag @janniks and @zone117x for review
@janniks janniks added the P2 label Feb 17, 2022
@janniks janniks added this to the Bundle Size Dependencies milestone Feb 23, 2022
@janniks janniks changed the title [Bundle Size][Encryption] Offload elliptic Offload elliptic from encryption Feb 23, 2022
@ahsan-javaid ahsan-javaid mentioned this issue Feb 28, 2022
Merged
9 tasks
@ahsan-javaid ahsan-javaid linked a pull request Feb 28, 2022 that will close this issue
[Bundle Size][Encryption] Use noble-secp256k1 to replace elliptic dependency #1200
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahsan-javaid ahsan-javaid

Labels
None yet
Projects
None yet
Milestone
Bundle Size Dependencies
Development

Successfully merging a pull request may close this issue.

[Bundle Size][Encryption] Use noble-secp256k1 to replace elliptic dependency hirosystems/stacks.js
2 participants
@janniks @ahsan-javaid