Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update receive modal with more complete options per type #3307

Closed
badonyx opened this issue Feb 27, 2023 · 3 comments · Fixed by #4122
Closed

Update receive modal with more complete options per type #3307

badonyx opened this issue Feb 27, 2023 · 3 comments · Fixed by #4122
Assignees
@pete-watters
Labels
area:bitcoin area:ordinals effort:small Expected to take up to 1 day of integration work enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@badonyx
Copy link

badonyx commented Feb 27, 2023

Screenshot 2023-02-27 at 10 26 58 AM

Primary concerns: Why do some of these have a QR button, some have a Copy button, and some both? Both options should be available for all types of address.

Secondary concerns: Why is the STX address duplicated, one without a QR? This has potential to increase rather than reduce confusion. (By the way, did you know that the 'T' in 'NFT' stands for 'Token'? FT and NFT are all "Tokens".)

A sensible iteration on this might simplify to 3 (or 2) options, with STX shown first (once), and Bitcoin addresses shown next. The Bitcoin address might be simplified to just taproot, since technically isn't any reason why inscribed and uninscribed sats need to be kept separate, assuming the wallet knows not to spend inscribed sats.

Furthermore, shouldn't legacy addresses still be supported for better compatibility? Legacy 1xyz/3xyz and native segwit bc1qxyz could all be hidden under some "advanced" option or something.
@markmhendrickson
Copy link
Collaborator

Primary concerns: Why do some of these have a QR button, some have a Copy button, and some both? Both options should be available for all types of address.

We've removed the copy option from Bitcoin so we can show a warning on the QR page re: not depositing ordinals. But I agree, we should find a way to put it back for convenience.

I also agree the QR code option should show for ordinals and Stacks NFTs.

Secondary concerns: Why is the STX address duplicated, one without a QR? This has potential to increase rather than reduce confusion. (By the way, did you know that the 'T' in 'NFT' stands for 'Token'? FT and NFT are all "Tokens".)

I imagine it could confuse, though we may have to see. The idea here is that the wallet now has two paths generally for FTs vs NFTs given the current intricacies of our ordinals support, so we wanted to bifurcate the experience. But as we build out feature parity for both, we could end up collapsing into one path again.

The Bitcoin address might be simplified to just taproot, since technically isn't any reason why inscribed and uninscribed sats need to be kept separate, assuming the wallet knows not to spend inscribed sats.

We may indeed want to do this once we have coin control in place for both Taproot and Native SegWit addresses. Right now if the user were to deposit inscriptions into the Native SegWit address, they could end up losing them upon sending BTC.

Furthermore, shouldn't legacy addresses still be supported for better compatibility?

We're assessing how much demand there is for legacy addresses and will add if it's significant.

@markmhendrickson markmhendrickson changed the title New 'receive' modal is confusing, incomplete Update receive modal with more complete options per type Feb 28, 2023
@github-project-automation github-project-automation bot moved this to Enhancements backlog in Hiro Wallet (DEPRECATED) Feb 28, 2023
@markmhendrickson markmhendrickson added Enhancement 💡 enhancement-p2 Critical functionality needed by few users, with no clear alternatives area:bitcoin area:ordinals labels Feb 28, 2023
@markmhendrickson markmhendrickson moved this from Enhancements backlog to Bugs backlog in Hiro Wallet (DEPRECATED) Feb 28, 2023
@markmhendrickson markmhendrickson moved this from Bugs backlog to Enhancements backlog in Hiro Wallet (DEPRECATED) Feb 28, 2023
@badonyx
Copy link
Author

badonyx commented Mar 1, 2023 •
edited
Loading

We're assessing how much demand there is for legacy addresses and will add if it's significant.

Miners and stackers need to use the legacy address but there is not currently a wallet that supports both the STX account and legacy BTC address. Furthermore, some stacking pools payout BTC to the legacy address. So this can be considered an important, if uncommon, utility for a Stacks wallet.

@markmhendrickson markmhendrickson moved this from Enhancements backlog to Assigned in Hiro Wallet (DEPRECATED) Aug 3, 2023
@pete-watters pete-watters moved this from Assigned to WIP in Hiro Wallet (DEPRECATED) Aug 11, 2023
pete-watters added a commit that referenced this issue Aug 11, 2023
@pete-watters
fix: add copy and qr options to receive modal, closes #3307
e78239f
pete-watters added a commit that referenced this issue Aug 11, 2023
@pete-watters
fix: add copy and qr options to receive modal, closes #3307
82925d6
@pete-watters pete-watters mentioned this issue Aug 11, 2023
Merged
@pete-watters pete-watters linked a pull request Aug 11, 2023 that will close this issue
Update receive modal with more complete options per type #4122
Merged
@pete-watters pete-watters moved this from WIP to Review in Hiro Wallet (DEPRECATED) Aug 11, 2023
@pete-watters pete-watters added the effort:small Expected to take up to 1 day of integration work label Aug 11, 2023
github-merge-queue bot pushed a commit that referenced this issue Aug 15, 2023
@pete-watters
fix: add copy and qr options to receive modal, closes #3307
efa14d0
@pete-watters
Copy link
Contributor

We have updated this to show more options and it will be available in the next release

@markmhendrickson markmhendrickson moved this from Review to Ready to release in Hiro Wallet (DEPRECATED) Aug 15, 2023
@fbwoolf fbwoolf mentioned this issue Aug 15, 2023
Merged
blockstack-devops pushed a commit that referenced this issue Aug 16, 2023
@semantic-release-bot
chore(release): 6.4.0
2fd7680 
## [6.4.0](v6.3.1...v6.4.0) (2023-08-16)

### Features

* updated bitcoin contract api, modified responses, added error handling ([3a77bfc](3a77bfc))

### Bug Fixes

* add copy and qr options to receive modal, closes [#3307](#3307) ([efa14d0](efa14d0))
* **firefox:** short session duration, closes [#4030](#4030) ([5a09c43](5a09c43))
* header indentation for Stacks transaction signing [#3881](#3881) ([8bfcf60](8bfcf60))

### Internal

* add modal for BTC Stamps QR receive ([fc33210](fc33210))
* inscription sends, closes [#4111](#4111) ([b2f0690](b2f0690))
* refactor receive modal to share code better ([77d8704](77d8704))
@markmhendrickson markmhendrickson moved this from Ready to release to Released or closed in Hiro Wallet (DEPRECATED) Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
area:bitcoin area:ordinals effort:small Expected to take up to 1 day of integration work enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update receive modal with more complete options per type leather-io/extension
3 participants
@markmhendrickson @pete-watters @badonyx