-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update receive modal with more complete options per type #4122
Conversation
}} | ||
title="Ordinal inscription" | ||
/> | ||
<ReceiveItem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't pass dataTestId
s to these two as I didn't add new tests for them.
I think it's basically the same as the tests above for HomePageSelectors.ReceiveBtcNativeSegwitQrCodeBtn
and HomePageSelectors.ReceiveStxQrCodeBtn
.
I can add some more tests if desired to make sure we catch each button scenario
080aea4
to
cb1bac1
Compare
children: React.ReactNode; | ||
title?: string; | ||
} | ||
export function ReceiveItems({ children, title }: ReceiveItemsProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another name for this could be ReceiveItemList
which avoids two very similar looking component names (only the s
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea, I'll update it thanks!
f41305a
to
7e1a6f1
Compare
@markmhx: I added a modal for I thought it cleaner to add a new route if we want to update the title. The easiest thing for now is probably not to change the title and use the same modal. Let me know if this is OK. @kyranjamie : Also let me know if this is OK. The PR should probably be un-approved if I push new commits |
LGTM! |
This PR:
Receive
modal where we show the copy icon when we should show QRreceive
modal to:pages/receive
receive
andreceive-collectibles
The refactor is in a separate commit so I can drop that easily if required.
I've tested it and it seems to be working as previously but with the new buttons:
Kapture.2023-08-11.at.14.09.21.mp4