Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not working properly if imported before devise-i18n #55

Open
dankimio opened this issue Jun 1, 2017 · 2 comments
Open

Not working properly if imported before devise-i18n #55

dankimio opened this issue Jun 1, 2017 · 2 comments
Labels
bug help wanted

Comments

@dankimio
Copy link
Collaborator

dankimio commented Jun 1, 2017 •
edited
Loading

Bootstrap styles are not applied with the following Gemfile:

# Views
gem 'devise-bootstrap-views', '~> 1.0.0.alpha1'
# I18n
gem 'devise-i18n'

However, it works if the gem is listed after devise-i18n:

# I18n
gem 'devise-i18n'
# Views
gem 'devise-bootstrap-views', '~> 1.0.0.alpha1'

It seems that devise-i18n is overriding views from devise-bootstrap-views. It should be fixed somehow or mentioned in README.
jfly pushed a commit to thewca/worldcubeassociation.org that referenced this issue Aug 20, 2018
@dependabot-support @jfly
Bump devise-bootstrap-views from 0.0.11 to 1.1.0 in /WcaOnRails
d5b48d3 
Bumps [devise-bootstrap-views](https://github.com/hisea/devise-bootstrap-views) from 0.0.11 to 1.1.0.
- [Release notes](https://github.com/hisea/devise-bootstrap-views/releases)
- [Commits](hisea/devise-bootstrap-views@v0.0.11...v1.1.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

Some manual changes by @jfly to get this working:
  - Move `gem 'devise-i18n'` before `gem 'devise-bootstrap-views'`. See hisea/devise-bootstrap-views#55.
  - Remove scss import of devise_bootstrap_views

After making these changes, I (@jfly) played around with each of the
routes listed on `bin/rake routes | grep devise`, and things seem to be
working fine.
jfly pushed a commit to thewca/worldcubeassociation.org that referenced this issue Aug 20, 2018
@dependabot-support @jfly
Bump devise-bootstrap-views from 0.0.11 to 1.1.0 in /WcaOnRails
704b7f8 
Bumps [devise-bootstrap-views](https://github.com/hisea/devise-bootstrap-views) from 0.0.11 to 1.1.0.
- [Release notes](https://github.com/hisea/devise-bootstrap-views/releases)
- [Commits](hisea/devise-bootstrap-views@v0.0.11...v1.1.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

Some manual changes by @jfly to get this working:
  - Move `gem 'devise-i18n'` before `gem 'devise-bootstrap-views'`. See hisea/devise-bootstrap-views#55.
  - Remove scss import of devise_bootstrap_views

After making these changes, I (@jfly) played around with each of the
routes listed on `bin/rake routes | grep devise`, and things seem to be
working fine.
@jfly jfly mentioned this issue Aug 20, 2018
Merged
jfly pushed a commit to thewca/worldcubeassociation.org that referenced this issue Aug 20, 2018
@dependabot-support @jfly
Bump devise-bootstrap-views from 0.0.11 to 1.1.0 in /WcaOnRails
da10614 
Bumps [devise-bootstrap-views](https://github.com/hisea/devise-bootstrap-views) from 0.0.11 to 1.1.0.
- [Release notes](https://github.com/hisea/devise-bootstrap-views/releases)
- [Commits](hisea/devise-bootstrap-views@v0.0.11...v1.1.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

Some manual changes by @jfly to get this working:
  - Move `gem 'devise-i18n'` before `gem 'devise-bootstrap-views'`. See hisea/devise-bootstrap-views#55.
  - Remove scss import of devise_bootstrap_views

After making these changes, I (@jfly) played around with each of the
routes listed on `bin/rake routes | grep devise`, and things seem to be
working fine.
@yaroslavrick
Copy link

rubocop want it be alphabetical order...
image

@dankimio
Copy link
Collaborator Author

rubocop want it be alphabetical order...
image

I also has this issue. I'm not sure if there's any solution other than ignoring the OrderedGems rule for these lines or adding a comment above gem 'devise-bootstrap-views'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dankimio @yaroslavrick