IStringLocalizer should look for {culture}.json

hishamco · Mar 3, 2020 · aee25f5 · aee25f5
1 parent 4f13064
commit aee25f5
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/samples/LocalizationSample/Resources/fr-FR.json b/samples/LocalizationSample/Resources/fr-FR.json
@@ -0,0 +1,3 @@
+{
+  "Hello": "Bonjour"
+}
diff --git a/samples/LocalizationSample/Startup.cs b/samples/LocalizationSample/Startup.cs
@@ -17,7 +17,7 @@ public void ConfigureServices(IServiceCollection services)
             services.AddJsonLocalization(options => options.ResourcesPath = "Resources");
         }
 
-        public void Configure(IApplicationBuilder app, IHostEnvironment env, IStringLocalizer<Startup> localizer)
+        public void Configure(IApplicationBuilder app, IHostEnvironment env, IStringLocalizer localizer1, IStringLocalizer<Startup> localizer2)
         {
             var supportedCultures = new List<CultureInfo>
             {
@@ -40,7 +40,8 @@ public void Configure(IApplicationBuilder app, IHostEnvironment env, IStringLoca
 
             app.Run(async (context) =>
             {
-                await context.Response.WriteAsync($"{localizer["Hello"]}!!");
+                await context.Response.WriteAsync($"{localizer1["Hello"]}!!");
+                await context.Response.WriteAsync($"{localizer2["Hello"]}!!");
             });
         }
 

diff --git a/src/My.Extensions.Localization.Json/JsonStringLocalizer.cs b/src/My.Extensions.Localization.Json/JsonStringLocalizer.cs
@@ -20,7 +20,7 @@ public class JsonStringLocalizer : IStringLocalizer
         private readonly ILogger _logger;
 
         private string _searchedLocation;
-        
+
         public JsonStringLocalizer(
             string resourcesPath,
             string resourceName,
@@ -160,11 +160,9 @@ private void BuildResourcesCache(string culture)
         {
             _resourcesCache.GetOrAdd(culture, _ =>
             {
-                var resourceFile = $"{culture}.json";
-                if (_resourceName != null)
-                {
-                    resourceFile = String.Join(".", _resourceName, resourceFile);
-                }
+                var resourceFile = string.IsNullOrEmpty(_resourceName)
+                    ? $"{culture}.json"
+                    : $"{_resourceName}.{culture}.json";
 
                 _searchedLocation = Path.Combine(_resourcesPath, resourceFile);
                 IEnumerable<KeyValuePair<string, string>> value = null;