osx : fix the inverted version test

[pmalhaire]

switched flags for this #728

[Explorer09]

Hello. I wonder what's the reason for inverting the function behavior of CompareKernelVersion() ?
Also, when we are improving the function, is it okay to add static qualifier to CompareKernelVersion? If you are familiar with C you know what it means.

[pmalhaire]

@Explorer09 I do invert the function because I made a mistake when l wrote it. See #728
It makes sense to make it static.

[pmalhaire]

@hishamhm I accidentaly inverted the test when I compacted the code. This is a fix for this

[ylluminarious]

@pmalhaire @Explorer09 After testing this patch on my own and verifying the test with some logging, I can confirm that this patch fixes the problem and it should no longer occur. Unless, of course, something other than DarwinProcess_scanThreads is causing the problem, but there is no evidence to indicate that.

[ylluminarious]

I applied this patch and left the resultant program running for 4 hours on 10.13.3 and didn't crash... I suggest that this patch be merged as soon as possible.

[hishamhm]

Merged! Thanks, @pmalhaire! A new release is coming this weekend!

[ylluminarious]

@hishamhm Thanks again! Sorry for the false relief in the previous PR... but thanks for your patience!

[pmalhaire]

@hishamhm thanks to you and sorry for the mess I made by inverting my test.
see you at FOSDEM