This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
Fix #define to match header when regenerating with MakeHeader.py #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fasterit The headers will be all re-generated by MakeHeader.py in the future, so all inconsistencies will be eliminated during the process. What I'm saying is: Your commit message about "to match header" will be unclear. It's better that you state about the missing parentheses and that's a regression of 47cf153 instead. |
|
You may change the commit message as you see fit. |
|
@fasterit merged, thank you! |
pneerincx
added a commit
to pneerincx/easybuild-easyconfigs
that referenced
this pull request
May 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from Debian https://sources.debian.org/src/htop/2.2.0-1/debian/patches/fix-linux-process.patch/
The LinuxProcess.h and LinuxProcess.c don't match which means htop 2.2.0 only compiles until you regen the header files. This fixes the inconsistency from 47cf153.
/DLange