Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): codegen: check before using in on nullable object #688

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

DrJume
Copy link
Contributor

@DrJume DrJume commented Feb 21, 2024

Fixes #686

Description

Adds a truthy-ness check before accessing object with in operator.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Fixes histoire-dev#686

Co-authored-by: Louis Haftmann <30736553+LouisHaftmann@users.noreply.github.com>
Copy link

codesandbox bot commented Feb 21, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

stackblitz bot commented Feb 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 60384f8
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/65d672ebb78e090008f11137
😎 Deploy Preview https://deploy-preview-688--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 60384f8
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/65d672ebb78e090008f11139
😎 Deploy Preview https://deploy-preview-688--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit 60384f8
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/65d672eb78cac00008156678
😎 Deploy Preview https://deploy-preview-688--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 60384f8
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/65d672ebacb96700086765fd
😎 Deploy Preview https://deploy-preview-688--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DrJume DrJume changed the title fix(codegen): don't run in on nullable object fix(codegen): check before using in on nullable object Feb 21, 2024
@Akryum Akryum changed the title fix(codegen): check before using in on nullable object fix(vue): codegen: check before using in on nullable object Mar 13, 2024
@Akryum Akryum merged commit 72a584b into histoire-dev:main Mar 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean breaks interface
2 participants