Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use !default in your variables _config.scss #2

Closed
zeroedin opened this issue Oct 15, 2014 · 6 comments
Closed

Use !default in your variables _config.scss #2

zeroedin opened this issue Oct 15, 2014 · 6 comments
Assignees

Comments

@zeroedin
Copy link

http://robots.thoughtbot.com/sass-default

This will allow me to use _sass-gridlover.scss but define my own config that overrides these preset defaults.

Maybe also consider name spacing your variables.

...
// Default font size.
// Don't change this variable!
$sgl-defaultFontSize: 16;

// Configurable variables.
// Ok... You can change these variables! :D
$sgl-baseFontSize: 18 !default;
$sgl-baseLineHeight: 1.2 !default;
$sgl-scaleFactor: $sgl-goldenSection !default;
zeroedin added a commit to wvu-patterns/wvu-patterns-starter-kit that referenced this issue Oct 15, 2014
@hiulit hiulit self-assigned this Oct 16, 2014
@hiulit
Copy link
Owner

hiulit commented Oct 16, 2014

Yeah, you're right! I wanted to do it anyway because of this amazing article https://medium.com/@marcmintel/write-sass-plugins-like-a-pro-c765ecf3af27, so, I'm into it.

@hiulit
Copy link
Owner

hiulit commented Oct 16, 2014

Done! Let me know if it works. And if it does, I'll publish a new release.

@hiulit
Copy link
Owner

hiulit commented Oct 16, 2014

I've closed the issue because I think I fixed it, but I'm waiting for you to try it and tell if it works properly to push the new release.

@hiulit
Copy link
Owner

hiulit commented Oct 20, 2014

Have you had the chance to try it?

@zeroedin
Copy link
Author

Yes, sorry I hadn't gotten back sooner, working as expected. Thanks.

@hiulit
Copy link
Owner

hiulit commented Oct 20, 2014

Nice! Well, I've just pushed a new release, 1.1.0, with your issue and a bunch of others, including SassDoc documentantion

zeroedin added a commit to wvu-patterns/wvu-patterns-starter-kit that referenced this issue Oct 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants