Optionally store audio without container; Unlock audio formats wav and wavpack

[MKO1640]

This patch will make it possible to store audio without putting it into any container. At the same time, it will unlock choosing the audio format from either "flac" (default), "wav" or "wavpack".

The patch supersedes #14.

[codecov]

Codecov Report

Merging #15 (fbe8928) into main (686aac2) will decrease coverage by 0.93%.
The diff coverage is 28.12%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   35.57%   34.63%   -0.94%     
==========================================
  Files           7        7              
  Lines         357      384      +27     
==========================================
+ Hits          127      133       +6     
- Misses        230      251      +21     

Flag	Coverage Δ
unittests	34.63% <28.12%> (-0.94%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
saraswati/cli.py	0.00% <0.00%> (ø)
saraswati/recorder.py	43.02% <27.58%> (-3.60%)	⬇️
saraswati/model.py	96.55% <100.00%> (+0.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686aac2...fbe8928. Read the comment docs.

[amotl]

Hi Michael,

thanks a stack for this excellent contribution. I just added some minor comments about "naming things". Thank you in advance for addressing them.

With kind regards,
Andreas.

[MKO1640]

Madness your speed borders on magic.
I'm just busy with something else but will then check it out extensively.
With kind regards,
Michael.

[MKO1640]

Quick test with all format options:
wav = checked
flac = checked
wavpack = checked
flac+ogg = checked
waw+ogg = checked
flac+mka = checked
waw+mka = checked
wavpack+ogg = broken - gst_parse_error: Delayed linking failed. (7) (./grammar.y(506): gst_parse_no_more_pads (): /GstPipeline:pipeline0/GstWavpackEnc:wavpackenc0
wavpac+mka = broken - failed delayed linking some pad of GstWavpackEnc named wavpackenc0 to pad audio_%u of GstSplitMuxSink named muxer

Status : I go back to the drawing board

[amotl]

Excellent! Don't worry about WavPack+container, it just doesn't work so we will have to investigate and/or ask upstream, see #7.

…

On 23 July 2021 05:22:13 CEST, MKO1640 ***@***.***> wrote: Quick test with all format options: wav = checked flac = checked wavpack = checked flac+ogg = checked waw+ogg = checked flac+mka = checked waw+mka = checked wavpack+ogg = broken - gst_parse_error: Delayed linking failed. (7) (./grammar.y(506): gst_parse_no_more_pads (): /GstPipeline:pipeline0/GstWavpackEnc:wavpackenc0 wavpac+mka = broken - failed delayed linking some pad of GstWavpackEnc named wavpackenc0 to pad audio_%u of GstSplitMuxSink named muxer Status : I go back to the drawing board -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #15 (comment)

-- Sent from my mind. This might have been typed on a mobile device, so please excuse my brevity.

[MKO1640]

Okay, thats a pity. Despite an intensive search, I have also not found a solution.
I learned a lot about gstreamer while searching for myself, which is also good.
Do I still have to do something on my side?
I've added a few forgotten commits.

best regards
Michael

[amotl]

Hi again, I believe the patch is fine. I will squash all commits into a single one and issue a new release after integrating it. Cheers, Andreas.

…

On 23 July 2021 17:37:52 CEST, MKO1640 ***@***.***> wrote: Okay, thats a pity. Despite an intensive search, I have also not found a solution. I learned a lot about gstreamer while searching for myself, which is also good. Do I still have to do something on my side? I've added a few forgotten commits. best regards Michael -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #15 (comment)

-- Sent from my mind. This might have been typed on a mobile device, so please excuse my brevity.