Nested Mqtt5Exceptions are now mapped to Mqtt3Exceptions #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… client was disconnected.
YannickWeber
approved these changes
Jul 31, 2019
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Mqtt5Exceptions are contained in strack traces of MQTT 3 clients, if they are the cause of aMqttSessionExpiredException.MqttPublish.receive(Now)does not throw if called after client was disconnected.Changes
Mqtt5Exceptions are now mapped toMqtt3ExceptionsMqttPublish.receive(Now)not throwing exception if called after client was disconnectedAsyncRuntimeException.fillInStackTrace, exception is now copied