Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added local bind address feature #365

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Added local bind address feature #365

merged 2 commits into from
Mar 13, 2020

Conversation

SgtSilvio
Copy link
Member

Motivation
Resolves #308

Changes

@cla-bot cla-bot bot added the cla-signed label Jan 22, 2020
@SgtSilvio SgtSilvio self-assigned this Jan 22, 2020
@SgtSilvio SgtSilvio linked an issue Feb 22, 2020 that may be closed by this pull request
Allow specifying a local bind-address #308
Closed
@SgtSilvio SgtSilvio force-pushed the feature/local-bind-adress branch 2 times, most recently from 3c3f94a to d976368 Compare March 13, 2020 09:44
@SgtSilvio SgtSilvio changed the base branch from develop-1-2 to develop March 13, 2020 09:49
@SgtSilvio SgtSilvio requested a review from sbaier1 March 13, 2020 09:49
sbaier1
sbaier1 approved these changes Mar 13, 2020
View reviewed changes
Copy link

@sbaier1 sbaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am assuming that null means "bind to the first available interface" as with the previous implementation?

LGTM in any case

@SgtSilvio
Copy link
Member Author

i am assuming that null means "bind to the first available interface" as with the previous implementation?

Yes

@SgtSilvio SgtSilvio merged commit 4f28d01 into develop Mar 13, 2020
@SgtSilvio SgtSilvio deleted the feature/local-bind-adress branch March 13, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbaier1 sbaier1 sbaier1 approved these changes

Assignees

@SgtSilvio SgtSilvio

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying a local bind-address
2 participants
@SgtSilvio @sbaier1