Improve Logging & Small fixes #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change properties name 'debug.level.shell' to 'logfile.level'
SgtSilvio
approved these changes
Dec 19, 2019
SgtSilvio
reviewed
Dec 19, 2019
SgtSilvio
reviewed
Dec 19, 2019
|
|
||
| // If the currently active shell client gets disconnected from the server prompt the user to enter | ||
| if (contextEqualsShellContext(context)) { | ||
| Logger.error(MqttUtils.getRootCause(cause).getMessage()); | ||
| Logger.error(cause, Throwables.getRootCause(cause).getMessage()); |
There was a problem hiding this comment.
Is this intended to pass cause and then the message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #110
Motivation
The previous logging was a bit confusing because there was no convention on what is written to the different log levels. Therefore, this PR updates to the most recent tinylog version and conventionalises log levels.
Changes
sub -sprinting the same received publish more than once