Ensure metadata refetched when language changes

hivtools · Nov 29, 2024 · 1e4fe1f · 1e4fe1f
1 parent 2679a5f
commit 1e4fe1f
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/src/app/static/src/app/store/language/actions.ts b/src/app/static/src/app/store/language/actions.ts
@@ -24,6 +24,10 @@ export const ChangeLanguageAction = async (context: ActionContext<RootState, Roo
 
     const actions: Promise<unknown>[] = [];
 
+    if (rootState.reviewInput.population.data !== null && rootGetters["baseline/complete"]) {
+        actions.push(dispatch("reviewInput/getPopulationDataset"));
+    }
+
     // Re-fetch input comparison data to get translated metadata if the data has previously been fetched
     if (rootState.reviewInput.inputComparison.data !== null && rootGetters["baseline/complete"] && rootGetters["surveyAndProgram/complete"]) {
         actions.push(dispatch("reviewInput/getInputComparisonDataset"));

diff --git a/src/app/static/src/tests/reviewInput/actions.test.ts b/src/app/static/src/tests/reviewInput/actions.test.ts
@@ -109,8 +109,7 @@ describe("reviewInput actions", () => {
             .mockImplementation(async (_metadata, _commit, _rootState, _rootGetters) => {});
         const mockFiltersAfterUseShapeRegions = vi
             .spyOn(utils, "filtersAfterUseShapeRegions")
-            .mockImplementation((...args) => [])
-        const deepFreeze = vi.spyOn(freezer, "deepFreeze");
+            .mockImplementation((...args) => []);
         await actions.getPopulationDataset({commit, rootState, rootGetters} as any);
 
         expect(commit).toHaveBeenCalledTimes(4);

diff --git a/src/app/static/src/tests/root/actions.test.ts b/src/app/static/src/tests/root/actions.test.ts
@@ -480,6 +480,11 @@ describe("root actions", () => {
                         loading: false,
                         error: null,
                         data: {} as any
+                    },
+                    population: {
+                        loading: false,
+                        error: null,
+                        data: {} as any
                     }
                 })
             });
@@ -491,9 +496,10 @@ describe("root actions", () => {
 
         expectChangeLanguageMutations(commit);
 
-        expect(dispatch.mock.calls.length).toBe(2);
-        expect(dispatch.mock.calls[0][0]).toStrictEqual("reviewInput/getInputComparisonDataset");
-        expect(dispatch.mock.calls[1][0]).toStrictEqual("modelCalibrate/getResult");
+        expect(dispatch.mock.calls.length).toBe(3);
+        expect(dispatch.mock.calls[0][0]).toStrictEqual("reviewInput/getPopulationDataset");
+        expect(dispatch.mock.calls[1][0]).toStrictEqual("reviewInput/getInputComparisonDataset");
+        expect(dispatch.mock.calls[2][0]).toStrictEqual("modelCalibrate/getResult");
     });
 
     it("changeLanguage does not fetch review input metadata if country code is empty", async () => {