Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NM-52] Add base map to bubble plot #1035

Merged
merged 5 commits into from
Nov 21, 2024
Merged

[NM-52] Add base map to bubble plot #1035

merged 5 commits into from
Nov 21, 2024

Conversation

krisdoyon
Copy link
Contributor

@krisdoyon krisdoyon commented Nov 20, 2024

Description

Adds the base map and associated checkbox that are currently in use with choropleth to output bubble plot. Refactored the checkbox into a separate component for consistent use in both maps. Checkbox now uses an emit which is handled in the parent component. Added logic to playwright test for output plots to test functionality similar to choropleth.

Type of version change

Patch

Checklist

  • I have incremented version number, or version needs no increment
  • The build passed successfully, or failed because of ADR tests

Copy link

@krisdoyon krisdoyon marked this pull request as ready for review November 21, 2024 12:58
@krisdoyon krisdoyon requested a review from r-ash November 21, 2024 12:58
Copy link
Collaborator

@r-ash r-ash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great, and code changes look great too. I wonder, can we make the text of "Show base map" also toggle the checkbox? I always go to click the text first but that doesn't work

@r-ash r-ash self-requested a review November 21, 2024 18:23
Copy link
Collaborator

@r-ash r-ash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks really good!

@r-ash r-ash merged commit d1e1821 into main Nov 21, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants