Fix issue with link to privacy and accessibility from login page not working #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-ash
commented
Nov 25, 2024
| </div> | ||
|
|
||
| <div id="partner-logos" class="logos d-flex justify-content-center mt-5"> | ||
| <a href="https://www.fjelltopp.org"><img src="public/images/fjelltopp_logo.png" class="small-logo"></a> |
There was a problem hiding this comment.
This was broken on production too, you can check by going to a non-existent root naomi.unaids.org/not/a/path
There was a problem hiding this comment.
Might consider adding target="_blank" attribute on each of the anchor tags here to force the URL to open in a new tab
There was a problem hiding this comment.
Good catch, thanks. Have updated that in this template and the login template.
r-ash
commented
Nov 25, 2024
| @@ -104,7 +104,7 @@ | |||
| </a> | |||
| </div> | |||
| </div> | |||
| <div id="spacer" class="flex-grow-1"></div> | |||
There was a problem hiding this comment.
Added some padding to this which I think improves the styling a bit
krisdoyon
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the current app if you try to go to privacy or accessibility from the login page you just get redirected back to login page again.
This PR fixes that by switching the history mode, I think this was what was causing the issue. See https://router.vuejs.org/guide/essentials/history-mode.html#HTML5-Mode for details, I think we are safe to switch because of the way we are serving the frontend from freemarker templates. At least comparing this to production, I can't notice any reason not to switch the history mode. Behaviour is the same, and we no longer have the ugly
#that gets put in the URL.Type of version change
Patches
Checklist