This repository has been archived by the owner on Dec 24, 2019. It is now read-only.
Handle pods with failed initcontainers or weird statuses #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
filter() returns a generator, not a list, so the next check will fail. Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
|
@aermakov-zalando is this still needed when we have zalando-incubator/kubernetes-on-aws#1668 ? |
|
We don't know yet if the TTL controller actually works. Plus it could be useful for other users? |
|
@aermakov-zalando OK, is this PR code now the actually tested code (after the fix of the fix)? I'm referring to zalando-incubator/kubernetes-on-aws#1674 |
|
It ran on my machine. :) We'll roll out the fix to all clusters soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle initContainers as well to avoid issues with pods that don't have a started container.