[macOS] fixes a bug broken application bundle will be built #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPack uses `CMAKE_INSTALL_PREFIX` and installs to its variable at running package process. Before the commit, `CMAKE_INSTALL_PREFIX` variable is expanded and CPack cannot install properly. Therefore, the macOS application bundle without `fixup_bundle` will be installed and packaged. The commit prevents expansion of `CMAKE_INSTALL_PREFIX` to resolve above problem.
Before the commit, installed macOS application bundle cannot execute and crash with `Code Signature Invalid` error due to GLES3 plugin linked with system OpenGL libraries. The commit prevents creating and installing unintended GLES3 plugin on macOS platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR fixes broken macOS application bundle will be built.
Note