Add Universal Search Suggestions

[Fefedu973]

[Insert URL to the plugin here]

[Adds search suggestions when typing something.]

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Requirements for your pull request

• You have read and understood the Contribution Guidelines.
• This pull request has a title in the format Add [Name of Plugin].
  • ✅ Add GEmojiSharp
  • ❌ Update readme.md
  • ❌ Adding GEmojiSharp
  • ❌ Added GEmojiSharp
• Your entry should include a short description of the plugin. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
  • ✅ - [GEmojiSharp](…) - Find and copy GitHub Emoji to the clipboard.
  • ❌ - [GEmojiSharp](…) - A GitHub Emoji plugin for PowerToys Run.
  • ❌ - [GEmojiSharp](…)
• The link text should be the Name of the plugin found in the plugin.json file. The URL should be the link to the GitHub repo, or a link to an anchor in the readme.
  • ✅ - [GEmojiSharp](https://github.com/hlaueriksson/GEmojiSharp) - …
  • ❌ - [GEmojiSharp.PowerToysRun](…) - …
  • ❌ - [GEmojiSharp](https://github.com/hlaueriksson/GEmojiSharp/releases/download/v1.0.0/GEmojiSharp.PowerToysRun.1.0.0.zip) - …
• Your entry should be added at the bottom of the appropriate category.

[Fefedu973]

@hlaueriksson

[hlaueriksson]

Hi @Fefedu973

Nice plugin!

It's similar to my Bang plugin.

I created an issue in your repo with feedback.

[Fefedu973]

Hi @Fefedu973

Nice plugin!

It's similar to my Bang plugin.

I created an issue in your repo with feedback.

Yeah I saw it, thanks !
The first time I saw your plugin was after I finished mine (I was a little sad to have done something that already existed lol) but they are not 100% the same so it is still nice.
It would be nice if you put your plugins on this page

[hlaueriksson]

Yeah, I should put my plugins here. Sometimes it feels awkward to toot my own horn.

[Fefedu973]

Yeah, I should put my plugins here. Sometimes it feels awkward to toot my own horn.

Yeah I understand (this what i though when i saw that you didn't put your own plugins on this page) but i think you deserve it and that thoses plugins deserve a place here

[Fefedu973]

Yeah, I should put my plugins here. Sometimes it feels awkward to toot my own horn.

The feedback has been taken into account !

[hlaueriksson]

Great work!

Can you update the PR title, name and description of the plugin?

[Fefedu973]

yeah !

[Fefedu973]

Done @hlaueriksson !

[Fefedu973]

Is there anything else I need to change or is this all good?

[Gtmz3]

Nice

[hlaueriksson]

@Fefedu973 thanks for your contribution. However I'm not comfortable merging this until Fefedu973/PowerToys-Run-Plugin-Updater#1 is fixed.

This list is curated and built on trust. I cannot endorse a plugin that fails to satisfy the Security Policy.

[Fefedu973]

@Fefedu973 thanks for your contribution. However I'm not comfortable merging this until Fefedu973/PowerToys-Run-Plugin-Updater#1 is fixed.

This list is curated and built on trust. I cannot endorse a plugin that fails to satisfy the Security Policy.

How can I fix that ? Should I sign my software by buying the expensive Microsoft thing ?
Should I setup my GitHub repo to build the software directly in GitHub to be sure that the given exe is safe (directly from the GitHub code) or should I change the main behavior of my code?
Idk

[hlaueriksson]

The idea of updating the plugin from the PowerToy Run context itself is awesome.

Instead of downloading an external winui app, is it possible to do the same thing from PowerToy Run?

The code could be distributed via a NuGet package and used by plugins with the DynamicLoading setting in plugin.json.

I'm wondering how antivirus providers will consider this approach?

[Fefedu973]

Oh no this means that I will need to throw my app away ): nevermind however the implementation of an updater directly in the plugin looks hard to me because while updating the plugin replaces its own files but the plugin needs to be running while doing the update process...

[Fefedu973]

Oh no this means that I will need to throw my app away ): nevermind however the implementation of an updater directly in the plugin looks hard to me because while updating the plugin replaces its own files but the plugin needs to be running while doing the update process...

[Fefedu973]

But I think powertoys should add themselves an plugin updater in their side because on the plugin json we are providing the GitHub url so they can check the updates like this

[hlaueriksson]

Hi @Fefedu973

I created a NuGet package that adds support for updating PowerToys Run Plugins:

• https://github.com/hlaueriksson/Community.PowerToys.Run.Plugin.Update

[Fefedu973]

Very nice! I'm going to replace my updater software with yours, (I'm a little bit sad because I put a lot of Elbow grease in this project but yours is better and pass the antivirus test)
Thanks!

[hlaueriksson]

I'm sorry if my feedback came across as harsh.

Code that you throw away is never wasted. It serves as a learning experience. 🌱

[Fefedu973]

I'm sorry if my feedback came across as harsh.

Code that you throw away is never wasted. It serves as a learning experience. 🌱

No this is not the feedback I fully understand but it is the code that I left behind, but you are right.
I'm currently trying to understand how to implement your package in my code but I wasn't able to understand the given code snippet in the readme, could you please explain to me briefly what are the different methods of the package and how to implement it In my case (I didn't understand for example why you set the plugin settings like this) I think that the given code lacks comments.
Thanks 👍

[hlaueriksson]

Take a look at the code here for now; https://github.com/hlaueriksson/GEmojiSharp/tree/master/src/GEmojiSharp.PowerToysRun

I will add better documentation in the readme tomorrow. 😇

[Fefedu973]

I have already tried but the code is almost the same. I'm going to wait for the doc then
Thanks

[hlaueriksson]

I have updated the docs.

[Fefedu973]

Thanks , I'll take a look

[hlaueriksson]

There are a few bugs I will try to fix in a 0.2.0 release.

[Fefedu973]

Okay nice

[Fefedu973]

the documentation is nice but the issue is with the main.cs code i really don't know why you manage settings like that or your code style in general. Is there anyway you give us just what we need to add to an aleready build project rather than a whole main.cs template where we are lost between what we should add to our code to make it work, what is aleready here but not exactly the same due to different coding styles. I think you get the point i'm lost lol 😭

[hlaueriksson]

Take a look at the sample project:

• https://github.com/hlaueriksson/Community.PowerToys.Run.Plugin.Update/tree/main/samples/Community.PowerToys.Run.Plugin.Sample

I created that with the dotnet new template:

• https://github.com/hlaueriksson/Community.PowerToys.Run.Plugin.Templates

And then I added Community.PowerToys.Run.Plugin.Update to it.

So, if you create your own project with:

dotnet new ptrun-proj -o Community.PowerToys.Run.Plugin.Sample

You can diff the two projects and figure out what changes are needed to support updates.

Like so:

[Fefedu973]

Oh, I didn't use that template for my project so this is why the coding style is different And I can't get out of it

[Fefedu973]

Oh, I didn't use that template for my project so this is why the coding style is different And I can't get out of it