Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blur editor #15

Merged
merged 9 commits into from
Mar 14, 2024
Merged

feat: add blur editor #15

merged 9 commits into from
Mar 14, 2024

Conversation

hoyaaaa
Copy link
Contributor

@hoyaaaa hoyaaaa commented Mar 14, 2024

Hi, I add blur editor

I would like to ask your opinion about my code.

i18n blurEditor

Property Description Default Value
applyBlurDialogMsg Text displayed when a filter is being applied 'Blur is being applied.'
bottomNavigationBarText Text for the bottom navigation bar item 'Blur'
back Text for the "Back" button in the Blur Editor 'Back'
done Text for the "Done" button in the Blur Editor 'Done'

Theme blurEditor

Property Description Default Value
appBarBackgroundColor Background color of the app bar in the blur editor. imageEditorAppBarColor (Default theme value)
appBarForegroundColor Foreground color (text and icons) of the app bar. Color(0xFFE1E1E1)
background Background color of the blur editor. imageEditorBackgroundColor (Default theme value)

icons blurEditor

Property Description Default Value
bottomNavBar Icon for bottom navigation bar Icons.blur_on

blurEditorConfigs

Property Description Default Value
enabled Indicates whether the blur editor is enabled. true
maxBlur The maximum of blur to apply. 2.0

hoyaaaa and others added 8 commits March 14, 2024 18:42
- Resolve issue where hero animation behaves incorrectly when the screen width exceeds image width in lib/modules/filter_editor/widgets/image_with_multiple_filters.dart.

feat: introduce blur editor feature in version 2.5.0

- Update CHANGELOG.md with version 2.5.0 changes.
@@ -47,6 +47,7 @@ class ImageWithMultipleFilters extends StatelessWidget {
}

return Stack(
alignment: Alignment.center,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hm21 hm21 merged commit 35b98da into hm21:stable Mar 14, 2024
@hm21
Copy link
Owner

hm21 commented Mar 14, 2024

Thank you for this fantastic new editor. I have reviewed all of your code, and it all looks great. I also love that you updated the state history import/export part, and also that your code style looks exactly the same as the other code. It feels like my code and your code are written by one person, which is amazing.

I only fixed one problem with the hero animation. But to be honest, hero animations is always a battle that they fly in a good way, especially when we work with Stack and Center widgets.

What we still have to do is to fix the unit tests. I saw that some of them failed because of an overflow issue. If I find time later, I can help to fix them, and then I will publish a new version of the editor with your code to pub.dev.
You fix the unit test faster than I can write ;) Okay, I already merged it and published it. Thanks again for this great feature.

@Kora3 Kora3 mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants