This repository has been archived by the owner on Nov 18, 2024. It is now read-only.
Bdog 1323 - Add Play 2.8 and drop Play 2.5 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-lamed
commented
Mar 9, 2021
| private val play25Version = "2.5.19" | ||
| private val play26Version = "2.6.23" // this version is pinned, since later versions are incompatible with the version of akka that reactivemongo was build with on scala 2.11. | ||
| private val play27Version = "2.7.4" | ||
| private val play26Version = "2.6.25" |
There was a problem hiding this comment.
version of Play 2.6 doesn't need pinning back now that we don't build for Scala 2.11
IanMcShane
previously approved these changes
Mar 9, 2021
build.sbt
Outdated
| ) | ||
| .settings( | ||
| scalaVersion := "2.11.12", | ||
| scalaVersion := "2.12.12", |
There was a problem hiding this comment.
Could the version be 2.12.13?
project/LibraryDependencies.scala
Outdated
| private val play27Version = "2.7.4" | ||
| private val play26Version = "2.6.25" | ||
| private val play27Version = "2.7.9" | ||
| private val play28Version = "2.8.4" |
There was a problem hiding this comment.
Latest version is 2.8.7.
IanMcShane
approved these changes
Mar 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.