Get metadata in a human-readable form from loaders #178
Conversation
| "@babel/core": "^7.9.0", | ||
| "@babel/plugin-transform-regenerator": "^7.8.7", | ||
| "@babel/plugin-transform-runtime": "^7.9.0", | ||
| "@babel/preset-env": "^7.8.3", | ||
| "@babel/preset-react": "^7.8.3", | ||
| "@babel/preset-env": "^7.9.0", | ||
| "@babel/preset-react": "^7.9.0", |
There was a problem hiding this comment.
What's up here? Just want to understand.
There was a problem hiding this comment.
I get this error when running npm run start using the package.json that is currently on the master branch. I think it may be due to the fact that I am on node 14, and it is possibly the same error that @manzt was seeing on travis last week. But upgrading these babel dependencies fixed it.
There was a problem hiding this comment.
However, if the package.json and package-lock changes should be in a different PR I can revert them
There was a problem hiding this comment.
No it's ok. Let me check this out and test.
|
Sorry, meant to approve, not review. Still curious about the comment though. |
|
Ok, the new babel seems to work for me on 13. |
|
Ok great |
This PR adds a
getMetadatafunction to both loaders. In the OMETiffLoader theomexmlvariable is used. In the ZarrLoader an empty object is returned. I am not sure whether the zarr files currently contain information that would match what is available inomexml.I had to upgrade babel because
npm run startthrew errors which is why the package.json changed.