Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to import MD as MarkdownIt's tokens #329

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Levyks
Copy link

@Levyks Levyks commented Aug 6, 2022

This should be useful in case you want to implement some sort of custom renderer for the markdown.

Currently, the only way to do this would be to parse the generated html client-side with htmlparser2 or something like that, which is not ideal performance wise

@hmsk
Copy link
Owner

hmsk commented Aug 7, 2022

Thanks for your contribution! Can you elaborate actual usage of this feature? I'd like to learn more about what this feature solves for users in real world.

At this moment, I would be reluctant to merge this feature since:

  • Exposing MarkdownIt specific tokens despite this plugin accepts any markdown compiler
  • The feature is a bit too abstract for usage (exposing markdown's parsing result might be helpful but I doubt that is a final outcome plugin's user wants)
    • When user wanna have "tokens", probably they intend to build something different outcome using the tokens...? Then markdown or markdownIt option would work for that case I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants