Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #1

Closed
elfring opened this issue Jul 6, 2018 · 8 comments
Closed

reserved identifier violation #1

elfring opened this issue Jul 6, 2018 · 8 comments
Assignees
@hnes
Labels
c-standard-compliance good first issue Good for newcomers

Comments

@elfring
Copy link

elfring commented Jul 6, 2018

I would like to point out that an identifier like “_ACO_H” does eventually not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?
@hnes hnes self-assigned this Jul 6, 2018
@hnes
Copy link
Owner

hnes commented Jul 6, 2018

Thank you very much, Markus, @elfring.

It is very kind of you to point out this mistake. I'll fix that immediately.

hnes added a commit that referenced this issue Jul 7, 2018
@hnes
fix some noncompliant include guards (issue #1, reported by Markus El…
8e43352 
…fring @elfring)
@hnes
Copy link
Owner

hnes commented Jul 7, 2018

This fix absolutely deserves the new patch release v1.2.1 .

@hnes
Copy link
Owner

hnes commented Jul 7, 2018

The release of v1.2.1 had already fixed such noncompliant definition of the macro name problem.

Thanks Markus for your report :D

@hnes hnes closed this as completed Jul 7, 2018
@elfring
Copy link
Author

elfring commented Jul 7, 2018

Thanks for your small source code improvement.

I suggest to reconsider also an identifier like “aco_s__”.

@hnes hnes reopened this Jul 7, 2018
@hnes
Copy link
Owner

hnes commented Jul 7, 2018

And also, the "__xmm*" identifiers have the same problem too. Thanks Markus :D

I'll fix them as soon as possible.

hnes added a commit that referenced this issue Jul 7, 2018
@hnes
again: fix some more noncompliant naming of identifiers (issue #1, re…
5d4c540 
…ported by Markus Elfring @elfring)
@elfring
Copy link
Author

elfring commented Jul 7, 2018

Will these source code adjustments have got any influence on the definition for an identifier like “ACO_VERSION_PATCH”?

@hnes
Copy link
Owner

hnes commented Jul 7, 2018

Yep... Bingo! Thank you very much, Markus.

hnes added a commit that referenced this issue Jul 7, 2018
@hnes
update the PATCH version (issue #1, reported by Markus Elfring @elfring)
91a951f
@hnes
Copy link
Owner

hnes commented Jul 9, 2018

Solved in the release of v1.2.2.

@hnes hnes closed this as completed Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hnes hnes

Labels
c-standard-compliance good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @hnes