-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged PHP7 and PHP5 code #31
base: master
Are you sure you want to change the base?
Conversation
2150cb9
to
64b8658
Compare
This still needs some fixes for PHP 5. I will review the changes and fix this. |
f9c13dc
to
4bce01f
Compare
4bce01f
to
d722041
Compare
This should also fix #30 - test added |
2a5ae6f
to
6fd3383
Compare
6fd3383
to
a34c5b1
Compare
zend_long sec, usec; | ||
#else | ||
long sec, usec; | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zend_long
always means 64bit integer on 64bit system, however long
has 32bit length on 64bit-Windows system. This fix causes backward-compatibility problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1f4b733
to
ef2ddad
Compare
ef2ddad
to
87c1e9a
Compare
@hnw Can you review this again? |
Ping @hnw :) |
@hnw ping |
This is the first step to merge the PHP5 and PHP7 code to ease the maintaining. I've tested it locally on 5.6 and 7.1.
The next step is to separate some of version-specific functions back to different files to make it more readable.