Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add isRefreshing and RefreshComponent props #112

Merged
merged 4 commits into from
Sep 9, 2021

Conversation

pdpino
Copy link
Collaborator

@pdpino pdpino commented Jun 20, 2021

(Partially) fixes #108

I added isRefreshing and RefreshComponent props, lmk what u think about this feature

@pdpino pdpino added the type: feature enhancements or new features label Jun 20, 2021
@dandresfg
Copy link

I'm taking a look to those changes and this is only an activity indicator. I mean scroll up at the top. Just like to refresh a page in chrome.

@pdpino
Copy link
Collaborator Author

pdpino commented Jul 12, 2021

@dandresfg I will answer in the issue, to keep the feature discussion there 🙂

@pdpino pdpino marked this pull request as draft August 19, 2021 00:13
@pdpino pdpino marked this pull request as ready for review September 8, 2021 16:29
@pdpino pdpino requested a review from hoangnm September 8, 2021 16:29
@hoangnm hoangnm merged commit b8e7763 into hoangnm:master Sep 9, 2021
@pdpino pdpino deleted the feature/spinner branch September 9, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature enhancements or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refershing/Refresh Control
3 participants