New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: change n days #126

Merged

hoangnm merged 2 commits into hoangnm:master from pdpino:hotfix/change-n-days

Aug 22, 2021

Collaborator

pdpino commented Aug 19, 2021 •

edited

Loading

Fixes #118

I applied a simple fix for this bug: whenever the numberOfDays prop changes --> recreates the initialDates array to avoid the inconsistencies
componentDidUpdate() will trigger an additional render --> not so efficient

I'm very busy at the moment, so I think we could apply this hotfix for now and come up with a better solution later. What do you think?

pdpino added 2 commits

July 13, 2021 17:15


          Hotfix: reset initialDates if n-days change

0ede741


          Merge branch 'master' into hotfix/change-n-days

2c26f8a

Owner

hoangnm commented Aug 22, 2021

I agree, we can apply the hotfix first.

hoangnm merged commit 1577dcb into hoangnm:master

pdpino deleted the hotfix/change-n-days branch

September 8, 2021 15:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet