Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add precision up to seconds in onGrid callbacks #149

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Add precision up to seconds in onGrid callbacks #149

merged 1 commit into from
Nov 28, 2021

Conversation

pdpino
Copy link
Collaborator

@pdpino pdpino commented Nov 25, 2021

Fixes #148

  • The startHour argument is redundant now (i.e. === date.getHours()), I'd say we can remove it in a future 1.x release? (would be a breaking change)

@pdpino pdpino added the type: feature enhancements or new features label Nov 25, 2021
@hoangnm
Copy link
Owner

hoangnm commented Nov 28, 2021

Thanks for the fix!

@hoangnm hoangnm merged commit fd6628a into hoangnm:master Nov 28, 2021
@pdpino pdpino deleted the feature/on-grid-press-precision branch January 5, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangnm hoangnm hoangnm left review comments

Assignees
No one assigned
Labels
type: feature enhancements or new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I want to get the minutes from OnGridClick, but im only getting the hours
2 participants
@pdpino @hoangnm