Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance by FlatList props and preserving Event ref #210

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Improve performance by FlatList props and preserving Event ref #210

merged 3 commits into from
Jun 1, 2022

Conversation

pdpino
Copy link
Collaborator

@pdpino pdpino commented May 24, 2022 •
edited
Loading

Performance improvements, part of #209

  • Enable profiling with android systrace (see DEVELOPING.md)
  • Optimize some FlatList props (following react-native recommendations)
    • --> Improves performance of scrolling horizontally
  • Preserve reference to each event instead of spreading (could allow memoizing or using a PureComponent in the future)

pdpino added 3 commits May 24, 2022 22:28
@pdpino
Add support for perf profiling in android
af57239 
In example app: enable hermes, build events more easily
@pdpino
Optimize FlatList props
02c588a 
windowSize, initialNumToRender, maxToRenderPerBatch
@pdpino
Preserve event ref
433662d 
Insteaf of copying by spreading
@hoangnm
Copy link
Owner

hoangnm commented Jun 1, 2022

thanks, LGTM.

@hoangnm hoangnm merged commit ee7859b into hoangnm:master Jun 1, 2022
@pdpino pdpino deleted the bug/performance branch June 1, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangnm hoangnm hoangnm left review comments

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdpino @hoangnm