Feature: press event to edit #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In WeekView state: initialDates
Move example use cases up in README Simplify common-usages.md
hoangnm
reviewed
Jul 18, 2022
src/Event/Event.styles.js
Outdated
| @@ -6,7 +6,7 @@ const styles = StyleSheet.create({ | |||
| position: 'absolute', | |||
| borderRadius: 0, | |||
| flex: 1, | |||
| overflow: 'hidden', | |||
| // overflow: 'hidden', | |||
There was a problem hiding this comment.
wait, but if we remove it, won't the event have any problem?
There was a problem hiding this comment.
I think there is no problem. It was there to avoid overflowing the text into the grid, but that does not occur anymore (I think since the usage of Animated.View, instead of View):
overflow-hidden-2022-07-18_15.45.09.mp4
|
Great feature! However, I see it supports editing horizontal, could you explain why? |
|
Here is an example of horizontal edition: edit-horizontally-2022-07-18_15.49.02.mp4I think it will also be useful with the block-like events #220 |
|
Amazing work! |
|
Awesome, the code looks great, thanks for this great feature @pdpino. |
|
Looks like we're gonna have a nice new release soon 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
rc1--2022-07-06_14.38.57.mp4
Here is an example usage of the API,
@hoangnm lmk if you have any comments (cc @rdewolff)