Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drag-config: afterLongPress #264

Merged
merged 7 commits into from
Sep 26, 2022
Merged

Add drag-config: afterLongPress #264

merged 7 commits into from
Sep 26, 2022

Conversation

pdpino
Copy link
Collaborator

@pdpino pdpino commented Sep 13, 2022 •
edited
Loading

Fixes #234. Provides a way to activate "drag-behavior" only after a longPress

v0-2022-09-13_12.55.39.mp4

Some ugly changes:

  • The code in Event.js is starting to get messy IMO (we can refactor this later)
  • New feature requires rn-gesture-handler >= v2.6.0 (upgrade is opt-in)

@pdpino pdpino added the type: feature enhancements or new features label Sep 13, 2022
@TheTushar2696 TheTushar2696 mentioned this pull request Sep 24, 2022
Closed
hoangnm
hoangnm reviewed Sep 25, 2022
View reviewed changes
src/Event/Event.js Outdated Show resolved Hide resolved
@hoangnm hoangnm merged commit 606c144 into hoangnm:master Sep 26, 2022
@pdpino pdpino deleted the feature/234-onlongpress-drag branch September 26, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangnm hoangnm hoangnm approved these changes

Assignees
No one assigned
Labels
type: feature enhancements or new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with the drag sensitivity
2 participants
@pdpino @hoangnm