-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: allow scrolling 1 day at the time #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow scrolling through day-offsets Add goToNextDay and goToPrevDay methods
Small code walkthrough - (in case is useful for reviewing the PR 🙂)
|
korifey91
reviewed
Sep 14, 2022
korifey91
reviewed
Sep 14, 2022
hoangnm
reviewed
Oct 7, 2022
hoangnm
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great
Amazing! Thanks for your hard work 🥳 |
Does the main README require some update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR overview - Change logic to allow scrolling one day at the time. This fixes multiple issues:
allowScrollByOneDay={true}
to scroll by days instead of by pagespageStartAt
, that allows customizing the date shown in the leftweekStartsOn
is removed. Instead, use proppageStartAt.weekday
(README has new prop details)left
option togoToDate(date, { left: number })
--> the date will show atnumber
of days from the left. i.e. Useleft = 0
to show the target date at the most leftanimated
, now is an object{ animated = true, left = null }
(README has signature details)goToNextDay()
andgoToPrevDay()
methodsallowScrollByOneDay={true}
and it should work