Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: pinch vertical gesture #316

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

pdpino
Copy link
Collaborator

@pdpino pdpino commented Jun 8, 2023

Fixes #130 (see demo in #130 (comment))

pdpino added 4 commits June 6, 2023 12:34
Add VerticalDimensionsContext with gesture and relevant dimensions
Extract vertical ScrollView into VerticalAgenda component
Refactor box start/endDate by timestamps
Update with new API
@pdpino pdpino added the type: feature enhancements or new features label Jun 8, 2023
@pdpino
Copy link
Collaborator Author

pdpino commented Aug 15, 2023

@hoangnm have u been able to check this PR?

Copy link
Owner

@hoangnm hoangnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@hoangnm hoangnm merged commit 7e72207 into hoangnm:master Aug 18, 2023
@pdpino pdpino deleted the feature/130-pinch-vertical branch September 5, 2023 14:02
@rdewolff
Copy link

rdewolff commented Sep 7, 2023

Deleted my previous message, did not see this message:

- Breaking change: add [react-native-gesture-handler](https://docs.swmansion.com/react-native-gesture-handler/docs/installation/) v2 and [react-native-reanimated](https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/installation) v2 as peer dependencies. This change helps drag&drop smoother [#175](https://github.com/hoangnm/react-native-week-view/pull/175)

All good 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature enhancements or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PinchGestureHandler
3 participants