Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use headerStyle.color #65

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Don't use headerStyle.color #65

merged 1 commit into from
Feb 13, 2021

Conversation

pdpino
Copy link
Collaborator

@pdpino pdpino commented Feb 7, 2021

Fixes #64

This is a (small) breaking change, as the text color should not be set in the headerStyle prop, but only in the headerTextStyle prop. (Only users setting the text-color via headerStyle.color would be affected)

@pdpino pdpino changed the title Dont access headerStyle.color Dont use headerStyle.color Feb 7, 2021
@pdpino pdpino changed the title Dont use headerStyle.color Don't use headerStyle.color Feb 7, 2021
@hoangnm
Copy link
Owner

hoangnm commented Feb 13, 2021

Thanks for the fix, @pdpino! I agree with your solution.

@hoangnm hoangnm merged commit f58322c into hoangnm:master Feb 13, 2021
@pdpino pdpino deleted the bug/style-color branch March 20, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example is not working
2 participants
@pdpino @hoangnm