-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: fixed-week behavior #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdpino
changed the title
Feature FixedWeekView component
Feature: FixedWeekView component
Apr 16, 2021
Hi @pdpino, thanks again for your help! I think we can have the prop to prevent horizontal scrolling at the moment unless we have more use cases for the FixedWeekView. |
Ok, sounds good I will refactor this PR soon! |
@hoangnm I updated the code and marked as ready:
|
Include now-line feature
Include changelog and readme fixes
AlissonEnz
approved these changes
May 20, 2021
Great, I'm merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74.
I created a
FixedWeekView
component, to be used as a fixed timetable showing one week.Some code is repeated from
WeekView
, which is not ideal (though I moved most functions toutils.js
). I created it this way for two main reasons:WeekView
component were to be reused, there would be useless virtualized-lists within the component, which is not optimalIf we wanted to avoid code repetition with a new component, instead of creating
FixedWeekView
as a component of its own, we could add a prop toWeekView
such asfixedHorizontally={true/false}
(or other name), which would disable horizontal scrolling, plus ensuring the week is displayed starting from monday.@hoangnm let me know if you prefer a different solution! The PR will be a draft for now.