Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Allow to disable default password log in after SSO is configured #406

Closed
MFYDev opened this issue Sep 22, 2024 · 1 comment
Closed

[Feature Request] Allow to disable default password log in after SSO is configured #406

MFYDev opened this issue Sep 22, 2024 · 1 comment
Labels
feature request New feature or request

Comments

@MFYDev
Copy link

MFYDev commented Sep 22, 2024

Reference: #92

Thank you for the wonderful project! And finally I can use SSO to secure my instance.

However after the SSO is set, can we add an env variable like DISABLE_DEFAULT_LOGIN or DISABLE_LOGIN_FORM to disable the default email and password log in form? Only through this way the SSO can properly protect the Hoarder itself.

Thank you so much for your effort again!
@MohamedBassem MohamedBassem added the feature request New feature or request label Sep 22, 2024
@IamTaoChen
Copy link

Maybe the DISABLE_SIGNUPS should be split for the local account and OIDC. OIDC account should be created automatically and the local account should be disable for signup.

kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Sep 23, 2024
@kamtschatka
[Feature Request] Allow to disable default password log in after SSO …
df29d6a 
…is configured hoarder-app#406

Added the DISABLE_LOCAL_SIGNUPS that can be used to force OAuth signups only
This was referenced Sep 23, 2024
Merged
Closed
MohamedBassem added a commit that referenced this issue Oct 6, 2024
@kamtschatka @MohamedBassem
feature: Allow disabling password signups (#413)
4a3775a 
* [Feature Request] Allow to disable default password log in after SSO is configured #406
Added the DISABLE_LOCAL_SIGNUPS that can be used to force OAuth signups only

* rename local signups to password signups

---------

Co-authored-by: MohamedBassem <me@mbassem.com>
kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Oct 6, 2024
@kamtschatka
[Feature Request] Allow to disable default password log in after SSO …
6d8f664 
…is configured hoarder-app#406

changed the flag to also disallow logging in via password
The extensions will also no longer be allowed to log in via username/password then
kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Oct 8, 2024
@kamtschatka
[Feature Request] Allow to disable default password log in after SSO …
721c7ab 
…is configured hoarder-app#406

added the error message for OAuth
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hoarder's Roadmap Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
Hoarder's Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MohamedBassem @IamTaoChen @MFYDev