Memory Leak?

[pinakure]

Hi, I've been using the library during a week, trying to port a Map Editor from another project. The project was going on without any trouble, and I was amazed by the library's easy of use, until stumbling on a weird behavior, rendering the whole program unpracticable. I need to know what on this function call is making the frame rate drop gradually, and make the execution slugish. If i coment all the drawing routines, the performance keeps stable, but I can see some ram usage raising eventually, guessing that's a python internal object management side effect.

The problematic code involves a single call to draw_rectangle, then a lot of draw_image calls.

Can anybody throw a solution? Getting out of ideas here...

[hoffstadt]

Do you mind showing a minimal example? Are you deleting the old draw items?

[pinakure]

Do you mind showing a minimal example? Are you deleting the old draw items?

w = target.width
h = target.height
width   = int(w >>5)
height  = int(h >>5)
sx = scroll.x if scroll.x < (self.width  - width ) else self.width  - width
sy = scroll.y if scroll.y < (self.height - height) else self.height - height
dx = sx + width
dy = sy + height
clean_color = (0, 0, 0, 255)
dpg.draw_rectangle((0,0), (w, h), fill=clean_color, color=clean_color, parent="mapzone",color_bottom_right=(0,0,255,255))
    for layer in range(0, self.layers):
        data = self.data[ layer ]
        tileset = tilesets.get(layer)
        width   = int(w / tileset.width)
        height  = int(h / tileset.height)
        sx = scroll.x if scroll.x < (self.width  - width ) else self.width  - width
        sy = scroll.y if scroll.y < (self.height - height) else self.height - height
        dx = sx + width
        dy = sy + height
        iy = 0
        color = (255,255,255,255) if Map.active_layer == layer else (200,200,255,32)
        for y in range(sy,dy):
            ix = 0
            position = (y*self.width)+sx
            for x in range(sx,dx):
                c = data[ position ]
                if c>=0:
                    #tile = tileset.tiles[c]
                    dpg.draw_image(
                        tileset.tag, 
                        (ix, iy), 
                        (ix+tileset.tiles[c].tileset.width, iy+tileset.tiles[c].tileset.height), 
                        uv_min=tileset.tiles[c].uv_min, 
                        uv_max=tileset.tiles[c].uv_max, 
                        parent="mapzone",
                        color=color
                    )
                position+=1
                ix+=tileset.width
            iy+=tileset.height

I guess you are on target with the deletion. Didn't read any of that on the docs either, but thanks for the clue, I'll test later and confirm it's the issue. Thank you very much.

[pinakure]

# Drawing pointers
background_item = None
draw_items      = []

def draw(self, target, tilesets, scroll=None):
    w = target.width
    h = target.height
    width   = int(w >>5)
    height  = int(h >>5)
    sx = scroll.x if scroll.x < (self.width  - width ) else self.width  - width
    sy = scroll.y if scroll.y < (self.height - height) else self.height - height
    dx = sx + width
    dy = sy + height
    clean_color = (0, 0, 0, 255)
    if Map.background_item:
        dpg.delete_item(Map.background_item) # delete ALL DRAW CALLS!!!
    Map.background_item = dpg.draw_rectangle(
        (0,0), (w, h), 
        fill=clean_color, 
        color=clean_color, 
        parent="mapzone",
        color_bottom_right=(0,0,255,255)
    )
    for a in Map.draw_items:
        dpg.delete_item(a) # delete ALL DRAW CALLS!!!
    Map.draw_items= []
    for layer in range(0, self.layers):
        data = self.data[ layer ]
        tileset = tilesets.get(layer)
        width   = int(w / tileset.width)
        height  = int(h / tileset.height)
        sx = scroll.x if scroll.x < (self.width  - width ) else self.width  - width
        sy = scroll.y if scroll.y < (self.height - height) else self.height - height
        dx = sx + width
        dy = sy + height
        iy = 0
        color = (255,255,255,255) if Map.active_layer == layer else (200,200,255,32)
        for y in range(sy,dy):
            ix = 0
            position = (y*self.width)+sx
            for x in range(sx,dx):
                c = data[ position ]
                if c>=0:
                    #tile = tileset.tiles[c]
                    Map.draw_items.append(dpg.draw_image(
                        tileset.tag, 
                        (ix, iy), 
                        (ix+tileset.tiles[c].tileset.width, iy+tileset.tiles[c].tileset.height), 
                        uv_min=tileset.tiles[c].uv_min, 
                        uv_max=tileset.tiles[c].uv_max, 
                        parent="mapzone",
                        color=color
                    ))
                position+=1
                ix+=tileset.width
            iy+=tileset.height

Indeed, it was a deletion issue. Lots of thanks again since I can continue the project now keeping the desired framerate.

[hoffstadt]

Awesome! It is a bit different that draw commands are items that require deletion in DPG but hey it is what it is. Glad it worked out!