Add match_id and game_number from Slippi v3.14.0 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacna
force-pushed
the
add-ranked-info
branch
from
7061015 to
09b7de5
Compare
|
Seems like the previous workflow was failing due to PEP-484. Rebased the changes in #45 to fix this |
davisdude
added a commit
to davisdude/py-slippi
that referenced
this pull request
Jul 4, 2023
hohav#44 commit 09b7de5 Author: isaac219 <isaac219@gmail.com> Date: Fri Dec 30 12:03:42 2022 -0500 Remove extra comment commit e68545f Author: isaac219 <isaac219@gmail.com> Date: Fri Dec 30 11:47:04 2022 -0500 Remove unnecessary lines commit 607b392 Author: isaac219 <isaac219@gmail.com> Date: Fri Dec 30 11:41:57 2022 -0500 Add match_id and game_number Co-authored-by: isaac219 <isaac219@gmail.com>
davisdude
added a commit
to davisdude/py-slippi
that referenced
this pull request
Jul 4, 2023
hohav#44 commit 09b7de5 Author: isaac219 <isaac219@gmail.com> Date: Fri Dec 30 12:03:42 2022 -0500 Remove extra comment commit e68545f Author: isaac219 <isaac219@gmail.com> Date: Fri Dec 30 11:47:04 2022 -0500 Remove unnecessary lines commit 607b392 Author: isaac219 <isaac219@gmail.com> Date: Fri Dec 30 11:41:57 2022 -0500 Add match_id and game_number Co-authored-by: isaac219 <isaac219@gmail.com>
davisdude
added a commit
to davisdude/py-slippi
that referenced
this pull request
Jul 4, 2023
hohav#44 commit 09b7de5 Author: isaac219 <isaac219@gmail.com> Date: Fri Dec 30 12:03:42 2022 -0500 Remove extra comment commit e68545f Author: isaac219 <isaac219@gmail.com> Date: Fri Dec 30 11:47:04 2022 -0500 Remove unnecessary lines commit 607b392 Author: isaac219 <isaac219@gmail.com> Date: Fri Dec 30 11:41:57 2022 -0500 Add match_id and game_number Co-authored-by: isaac219 <isaac219@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
match_idandgame_numberthat were added in addition to ranked in Slippi 3.14.0 as described here. Formatch_id, we remove the null terminators when returning inStart.Testing
Added unit test with v3.14.0
.slpfile