Sign batched queued mints transaction #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kespinola
reviewed
Oct 17, 2023
api/src/events/solana.rs
Outdated
Comment on lines
233
to
250
| for (sig1, sig2, sig3) in signatures { | ||
| let key = key.clone(); | ||
|
|
||
| let sig1_bytes = <[u8; 64]>::from_hex(sig1.signature.full_sig)?; | ||
| let sig1 = bs58::encode(sig1_bytes).into_string(); | ||
|
|
||
| let sig3_bytes = <[u8; 64]>::from_hex(sig3.signature.full_sig)?; | ||
| let sig3 = bs58::encode(sig3_bytes).into_string(); | ||
|
|
||
| let mut signed_message_signatures = vec![sig1, sig3]; | ||
|
|
||
| // this will be true if mint is uncompressed | ||
| if let Some(sig2) = sig2 { | ||
| signed_message_signatures.insert(1, sig2); | ||
| } | ||
|
|
||
| let txn = SolanaTransactionResult { | ||
| serialized_message: None, |
There was a problem hiding this comment.
what is happening here? Why assume 3 sigs?
There was a problem hiding this comment.
Ok this is a dedicated handler for the mint batched that is better.
There was a problem hiding this comment.
uncompressed mint has one extra signature at idx 1 . Maybe there is a cleaner way to do this.
kespinola
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.