Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: portfolio custom feed item #69

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

georgeciubotaru
Copy link
Contributor

resolves #42

estimation: 1h

@georgeciubotaru georgeciubotaru self-assigned this Apr 14, 2023
@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holdex-venture-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 7:11am

@markholdex markholdex linked an issue Apr 17, 2023 that may be closed by this pull request
5 tasks
@markholdex
Copy link
Contributor

@predrag-us can you test the new portfolio out and leave your feedback? Click Visit Preview from the top of this page. Thx

@predrag-us
Copy link

@markholdex @georgeciubotaru

Nearly there, noticed a few things:

  • Tags should have maxed border-radius, instead of "button shape"
  • Paragraph font-size should be smaller on smaller screens
  • The gap between text elements should be smaller on smaller screens
  • Updated cover images don't work on smaller screens (screenshots)

CleanShot 2023-04-17 at 10 38 36@2x

CleanShot 2023-04-17 at 10 38 44@2x

@markholdex
Copy link
Contributor

@predrag-us can you prepare some cover images but make sure the logotypes are visible on desktop, mobile and in chats (OG image)

@predrag-us
Copy link

@markholdex @georgeciubotaru

Updated:

  • Portfolio OG Images
  • Portfolio Cover Images

Everything should be fine now, in combination with the required fixes mentioned in my previous comment.

@georgeciubotaru
Copy link
Contributor Author

@predrag-us Give it a try now

@predrag-us
Copy link

@georgeciubotaru All good!

@georgeciubotaru georgeciubotaru merged commit 67cfdbb into stage Apr 18, 2023
@georgeciubotaru georgeciubotaru deleted the feat/portfolio-feed branch April 18, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom feed page for Portfolio items
3 participants