chore: remove trigger v2 code #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request involves the comprehensive removal of the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
77-80: Add language identifier to code block.Add a language identifier to the fenced code block:
- ``` + ```env TRIGGER_SERVER_URL=<your-local-webhook-server-url> TRIGGER_SERVER_SECRET=<your-local-webhook-secret> ```🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
77-77: Fenced code blocks should have a language specified
null(MD040, fenced-code-language)
48-48: Fix article usage.Replace "an" with "a" before "ngrok":
-- `proxy`: Creates an ngrok tunnel with a specific domain for development ++ `proxy`: Creates a ngrok tunnel with a specific domain for development🧰 Tools
🪛 LanguageTool
[misspelling] ~48-~48: Use “a” instead of ‘an’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’.
Context: ...nd syncing SvelteKit -proxy: Creates an ngrok tunnel with a specific domain for...(EN_A_VS_AN)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (21)
docs/images/local-development-setup/dependencies-installations.pngis excluded by!**/*.pngdocs/images/local-development-setup/docker-compose-up-success.pngis excluded by!**/*.pngdocs/images/local-development-setup/github-access-token.pngis excluded by!**/*.pngdocs/images/local-development-setup/local-triggerdotdev-1.pngis excluded by!**/*.pngdocs/images/local-development-setup/local-triggerdotdev-10.pngis excluded by!**/*.pngdocs/images/local-development-setup/local-triggerdotdev-11.pngis excluded by!**/*.pngdocs/images/local-development-setup/local-triggerdotdev-2.pngis excluded by!**/*.pngdocs/images/local-development-setup/local-triggerdotdev-3.pngis excluded by!**/*.pngdocs/images/local-development-setup/local-triggerdotdev-4.pngis excluded by!**/*.pngdocs/images/local-development-setup/local-triggerdotdev-5.pngis excluded by!**/*.pngdocs/images/local-development-setup/local-triggerdotdev-6.pngis excluded by!**/*.pngdocs/images/local-development-setup/local-triggerdotdev-7.pngis excluded by!**/*.pngdocs/images/local-development-setup/local-triggerdotdev-8.pngis excluded by!**/*.pngdocs/images/local-development-setup/local-triggerdotdev-9.pngis excluded by!**/*.pngdocs/images/local-development-setup/supabase-db-setup-1.pngis excluded by!**/*.pngdocs/images/local-development-setup/supabase-db-setup-2.pngis excluded by!**/*.pngdocs/images/local-development-setup/telebit-proxy.pngis excluded by!**/*.pngdocs/images/local-development-setup/telebit-setup-1.pngis excluded by!**/*.pngdocs/images/local-development-setup/telebit-setup-2.pngis excluded by!**/*.pngintegrations/autoinvoicing/pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (34)
.github/workflows/integrations_autoinvoicing.yml(0 hunks).npmrc.example(0 hunks)README.md(1 hunks)container/.env.example(0 hunks)container/docker-compose.yml(0 hunks)integrations/autoinvoicing/.gitignore(0 hunks)integrations/autoinvoicing/package.json(0 hunks)integrations/autoinvoicing/src/checks.ts(0 hunks)integrations/autoinvoicing/src/compound.ts(0 hunks)integrations/autoinvoicing/src/git.ts(0 hunks)integrations/autoinvoicing/src/index.ts(0 hunks)integrations/autoinvoicing/src/issues.ts(0 hunks)integrations/autoinvoicing/src/orgs.ts(0 hunks)integrations/autoinvoicing/src/propertyHelpers.ts(0 hunks)integrations/autoinvoicing/src/reactions.ts(0 hunks)integrations/autoinvoicing/src/repos.ts(0 hunks)integrations/autoinvoicing/src/sources.ts(0 hunks)integrations/autoinvoicing/tsconfig.json(0 hunks)integrations/autoinvoicing/tsup.config.ts(0 hunks)package.json(1 hunks)src/lib/server/trigger-dev/client.ts(0 hunks)src/lib/server/trigger-dev/fix-pr.ts(0 hunks)src/lib/server/trigger-dev/index.ts(0 hunks)src/lib/server/trigger-dev/jobs/check-run.ts(0 hunks)src/lib/server/trigger-dev/jobs/index.ts(0 hunks)src/lib/server/trigger-dev/jobs/issues-comment.ts(0 hunks)src/lib/server/trigger-dev/jobs/issues-creation.ts(0 hunks)src/lib/server/trigger-dev/jobs/issues.ts(0 hunks)src/lib/server/trigger-dev/jobs/pull-requests-review.ts(0 hunks)src/lib/server/trigger-dev/jobs/pull-requests.ts(0 hunks)src/lib/server/trigger-dev/utils.ts(0 hunks)src/routes/api/submissions/+server.ts(1 hunks)src/routes/api/trigger/+server.ts(0 hunks)tsconfig.json(1 hunks)
💤 Files with no reviewable changes (30)
- src/lib/server/trigger-dev/index.ts
- integrations/autoinvoicing/package.json
- container/docker-compose.yml
- src/routes/api/trigger/+server.ts
- integrations/autoinvoicing/.gitignore
- integrations/autoinvoicing/tsconfig.json
- src/lib/server/trigger-dev/jobs/index.ts
- .npmrc.example
- .github/workflows/integrations_autoinvoicing.yml
- integrations/autoinvoicing/src/propertyHelpers.ts
- integrations/autoinvoicing/tsup.config.ts
- integrations/autoinvoicing/src/git.ts
- integrations/autoinvoicing/src/checks.ts
- src/lib/server/trigger-dev/jobs/check-run.ts
- src/lib/server/trigger-dev/jobs/issues.ts
- integrations/autoinvoicing/src/issues.ts
- src/lib/server/trigger-dev/client.ts
- src/lib/server/trigger-dev/jobs/issues-comment.ts
- integrations/autoinvoicing/src/compound.ts
- src/lib/server/trigger-dev/utils.ts
- integrations/autoinvoicing/src/orgs.ts
- integrations/autoinvoicing/src/sources.ts
- container/.env.example
- src/lib/server/trigger-dev/jobs/pull-requests.ts
- integrations/autoinvoicing/src/index.ts
- integrations/autoinvoicing/src/repos.ts
- src/lib/server/trigger-dev/jobs/pull-requests-review.ts
- integrations/autoinvoicing/src/reactions.ts
- src/lib/server/trigger-dev/jobs/issues-creation.ts
- src/lib/server/trigger-dev/fix-pr.ts
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~33-~33: Loose punctuation mark.
Context: ...``` Configuration parameters: - name: Your GitHub organization slug - `nodeId...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~38-~38: Loose punctuation mark.
Context: ...) ## Available Scripts - postinstall: Sets up Husky for Git hooks - `pull-env...
(UNLIKELY_OPENING_PUNCTUATION)
[misspelling] ~48-~48: Use “a” instead of ‘an’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’.
Context: ...nd syncing SvelteKit - proxy: Creates an ngrok tunnel with a specific domain for...
(EN_A_VS_AN)
🪛 markdownlint-cli2 (0.17.2)
README.md
77-77: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
🔇 Additional comments (1)
tsconfig.json (1)
17-17: LGTM! Path alias removal is consistent with PR objective.The removal of the trigger-related path alias aligns with the goal of removing trigger v2 code.
georgeciubotaru
approved these changes
Jan 30, 2025
|
@georgeciubotaru |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #372
read new readme: https://github.com/holdex/pr-time-tracker/tree/chore/remove-v2
Summary by CodeRabbit
Based on the comprehensive summary, here are the release notes:
Removal of Integration
@holdex/autoinvoicingGitHub integration package and related filesConfiguration Changes
package.jsonTrigger.dev Integration
Error Handling
These changes represent a significant restructuring of the project's integration and automation capabilities, focusing on simplifying the codebase and removing specific GitHub-related integrations.