Use bee's state at diffStream creation time #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour of the streams is unintuitive: the resulting stream can include entries not yet present at the time of creating the stream (no snapshot is taken).
A straightforward solution: use snapshots when creating the stream. I think this conforms more to user expectation: when creating a diffStream, I expect the diffStream at the time I asked for it, not the diffStream of some future state of the bee.
Simple example:
See the test for how to trigger the race condition (it's tricky)
This applies to diffStream, readStream and historyStream. Holding off on implementing the fix for readStream and historyStream until sure the proposed solution is good.