Add upload, download and append stats #553
Conversation
|
Marking this as draft--it needs an iteration on where these stats should live exactly |
| ready () { | ||
| return this.opening | ||
| } | ||
|
|
||
| _onupload (index, value, from) { | ||
| const byteLength = value.byteLength - this.padding | ||
|
|
||
| this.core.stats.blocksUploaded++ | ||
| this.core.stats.bytesUploaded += byteLength |
There was a problem hiding this comment.
should not live in the sesison, move to replicator or who ever is triggering this
There was a problem hiding this comment.
This is emitted from the replicator, but the replicator has no direct access to the byteLength as calculated here, so I need to look into another way to calculate that (from what I can tell, it has no access to info about the encryption and its padding, but it can probably know the byte length of the block by checking Hypercore.core, which it does have access to).
There was a problem hiding this comment.
byteLength is value.byteLength, this is actualy wrong from a stats pov
There was a problem hiding this comment.
the padding is due to the session being encrypted, nothing to do with the size of the block it pulled from the network
| @@ -711,6 +727,9 @@ module.exports = class Hypercore extends EventEmitter { | |||
| if (value) { | |||
| const byteLength = value.byteLength - this.padding | |||
|
|
|||
| this.core.stats.blocksDownloaded++ | |||
| this.core.stats.bytesDownloaded += byteLength | |||
| } | ||
|
|
||
| this.core.stats.blocksAppended += blocks.length | ||
| this.core.stats.bytesAppended += totalByteLength |
There was a problem hiding this comment.
move to core.append instead of the session
The way of passing the stats object to all sessions is pretty ad-hoc--if there's a cleaner, more explicit way, that would be preferable,stats now live in Core instead