Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply isort #209

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Apply isort #209

merged 1 commit into from
Nov 8, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jun 2, 2023 •
edited
Loading

Not that I necessarily agree with all isort choices, but the result is consistent and readable imports

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the isort branch 2 times, most recently from 593f362 to ee88a59 Compare June 3, 2023 08:24
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the isort branch 2 times, most recently from c4c3f84 to 0905ef5 Compare July 2, 2023 20:40
@skjerns
Copy link
Collaborator

skjerns commented Nov 8, 2023

I think that's a good idea - would you be willing to update this for the current master branch?

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Nov 8, 2023 •
edited
Loading

Done. This time I actually ran ruff check --select I001 --fix instead of isort.

@skjerns skjerns merged commit ae77312 into holgern:master Nov 8, 2023
24 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the isort branch November 8, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @skjerns